git-echo/linux_patch_api
Private
Public Access
1
0
Fork 0
Code Releases 32 Wiki Activity

fix(tests): resolve all clippy warnings for CI compliance

Browse Source 
- Remove needless borrows on format!() in set_body_string() calls (needless_borrows_for_generic_args)
- Replace assert!(false, ...) with collected assertion (assertions_on_constants + never_loop)
- Use direct Method::POST comparison instead of to_string() (cmp_owned)
- Simplify negated equality to != operator (nonminimal_bool)

CI pipeline now passes with -D warnings enabled
This commit is contained in:
Echo
2026-05-17 16:02:57 +00:00
parent a08145ed9e
commit 8bfa5f2273
3 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/e2e/test_enrollment_e2e.rs
View File

@ -120,7 +120,7 @@ async fn test_full_enrollment_flow_happy_path() {
.and(path("/api/v1/enroll"))
.respond_with(
ResponseTemplate::new(202)
.set_body_string(&format!(r#"{{"polling_token": "{}"}}"#, TEST_TOKEN)),
.set_body_string(format!(r#"{{"polling_token": "{}"}}"#, TEST_TOKEN)),
)
.named("enroll_registration")
.mount(&server)
@ -135,7 +135,7 @@ async fn test_full_enrollment_flow_happy_path() {
ResponseTemplate::new(200).set_body_string(r#"{"status": "pending"}"#)
} else {
// Second poll returns approved with full PKI bundle
ResponseTemplate::new(200).set_body_string(&format!(
ResponseTemplate::new(200).set_body_string(format!(
r#"{{
"status": "approved",
"ca_crt": {},
@ -414,7 +414,7 @@ async fn test_certificate_permission_verification() {
Mock::given(method("GET"))
.and(path_regex(r"/api/v1/enroll/status/.+"))
.respond_with(ResponseTemplate::new(200).set_body_string(&format!(
.respond_with(ResponseTemplate::new(200).set_body_string(format!(
r#"{{
"status": "approved",
"ca_crt": {},
@ -529,7 +529,7 @@ async fn test_whitelist_append_verification() {
Mock::given(method("GET"))
.and(path_regex(r"/api/v1/enroll/status/.+"))
.respond_with(ResponseTemplate::new(200).set_body_string(&format!(
.respond_with(ResponseTemplate::new(200).set_body_string(format!(
r#"{{
"status": "approved",
"ca_crt": {},
@ -663,14 +663,15 @@ async fn test_signal_handling_during_polling() {
);
// Verify: cleanup of any partial state (no leftover files)
for entry in std::fs::read_dir(cert_dir.path()).unwrap() {
let entry = entry.unwrap();
assert!(
false,
"No partial files should remain after graceful shutdown: {}",
entry.file_name().to_string_lossy()
);
}
let remaining: Vec<_> = std::fs::read_dir(cert_dir.path())
.unwrap()
.map(|e| e.unwrap().file_name().to_string_lossy().to_string())
.collect();
assert!(
remaining.is_empty(),
"No partial files should remain after graceful shutdown: {:?}",
remaining
);
}
// =============================================================================
@ -703,7 +704,7 @@ async fn test_whitelist_yaml_format_preservation() {
Mock::given(method("GET"))
.and(path_regex(r"/api/v1/enroll/status/.+"))
.respond_with(ResponseTemplate::new(200).set_body_string(&format!(
.respond_with(ResponseTemplate::new(200).set_body_string(format!(
r#"{{
"status": "approved",
"ca_crt": {},