Private
Public Access
1
0

Compare commits

...

16 Commits

Author SHA1 Message Date
6ba708abb1 fix: remove all systemd capability restrictions blocking package management
Some checks failed
CI/CD Pipeline / Code Format (push) Successful in 1s
CI/CD Pipeline / Clippy Lints (push) Successful in 43s
CI/CD Pipeline / Unit Tests (push) Successful in 57s
CI/CD Pipeline / Security Audit (push) Successful in 5s
CI/CD Pipeline / Build Arch Package (push) Successful in 2m10s
CI/CD Pipeline / Build Alpine Package (push) Successful in 3m19s
CI/CD Pipeline / Build RPM Package (push) Successful in 3m2s
CI/CD Pipeline / Build Debian Package (push) Has started running
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Failing after 15m44s
- Remove CapabilityBoundingSet and AmbientCapabilities (apt needs full root capabilities)
- Remove ReadWritePaths (unnecessary without ProtectSystem=strict)
- Fix E2E test: properly FAIL on status=failed package operations
- Fix E2E test: require status=completed for install/update/remove lifecycle
- Update dpkg packaging service file to match configs/
- Bump version to 0.3.5
2026-05-03 04:13:50 +00:00
de7ec9905f fix: correct Cargo.toml version to 0.3.4
All checks were successful
CI/CD Pipeline / Code Format (push) Successful in 1s
CI/CD Pipeline / Clippy Lints (push) Successful in 53s
CI/CD Pipeline / Unit Tests (push) Successful in 1m39s
CI/CD Pipeline / Security Audit (push) Successful in 4s
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Successful in 1m52s
CI/CD Pipeline / Build Arch Package (push) Successful in 1m55s
CI/CD Pipeline / Build Alpine Package (push) Successful in 3m32s
CI/CD Pipeline / Build Debian Package (push) Successful in 2m27s
CI/CD Pipeline / Build RPM Package (push) Successful in 3m26s
2026-05-03 03:11:52 +00:00
508037d656 chore: bump version to 0.3.4 for clean CI build
Some checks failed
CI/CD Pipeline / Code Format (push) Successful in 3s
CI/CD Pipeline / Unit Tests (push) Has been cancelled
CI/CD Pipeline / Security Audit (push) Has been cancelled
CI/CD Pipeline / Build Debian Package (push) Has been cancelled
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Has been cancelled
CI/CD Pipeline / Build RPM Package (push) Has been cancelled
CI/CD Pipeline / Build Alpine Package (push) Has been cancelled
CI/CD Pipeline / Build Arch Package (push) Has been cancelled
CI/CD Pipeline / Clippy Lints (push) Has been cancelled
2026-05-03 03:11:41 +00:00
56de1d73e1 fix(ci): prevent recursive tag triggers and u2204 release duplication
Some checks failed
CI/CD Pipeline / Build RPM Package (push) Has been cancelled
CI/CD Pipeline / Unit Tests (push) Has been cancelled
CI/CD Pipeline / Security Audit (push) Has been cancelled
CI/CD Pipeline / Build Debian Package (push) Has been cancelled
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Has been cancelled
CI/CD Pipeline / Build Alpine Package (push) Has been cancelled
CI/CD Pipeline / Build Arch Package (push) Has been cancelled
CI/CD Pipeline / Code Format (push) Has been cancelled
CI/CD Pipeline / Clippy Lints (push) Has been cancelled
- Change tag trigger from v* to v*.*.* to prevent recursive CI runs
- Upload u2204 deb to same release tag (not creating -u2204 suffix)
- Rename u2204 deb filename to include u2204 for differentiation
2026-05-03 02:49:18 +00:00
157376af7e chore: bump version to 0.3.3 for dpkg and service fixes
Some checks failed
CI/CD Pipeline / Code Format (push) Successful in 2s
CI/CD Pipeline / Clippy Lints (push) Successful in 49s
CI/CD Pipeline / Unit Tests (push) Successful in 57s
CI/CD Pipeline / Security Audit (push) Successful in 4s
CI/CD Pipeline / Build Arch Package (push) Successful in 1m56s
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Successful in 1m58s
CI/CD Pipeline / Build Alpine Package (push) Successful in 3m27s
CI/CD Pipeline / Build RPM Package (push) Successful in 4m2s
CI/CD Pipeline / Build Debian Package (push) Has been cancelled
2026-05-03 02:35:32 +00:00
77e8ac2e65 fix: remove linux-patch-api user from dpkg scripts, change ownership to root
All checks were successful
CI/CD Pipeline / Code Format (push) Successful in 1s
CI/CD Pipeline / Clippy Lints (push) Successful in 46s
CI/CD Pipeline / Unit Tests (push) Successful in 58s
CI/CD Pipeline / Security Audit (push) Successful in 4s
CI/CD Pipeline / Build Arch Package (push) Successful in 1m55s
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Successful in 1m59s
CI/CD Pipeline / Build Alpine Package (push) Successful in 3m17s
CI/CD Pipeline / Build RPM Package (push) Successful in 3m42s
CI/CD Pipeline / Build Debian Package (push) Successful in 2m2s
- Remove user/group creation from preinst (service runs as root)
- Change directory ownership to root:root in preinst and postinst
- Remove user/group deletion from postrm
- Service runs as root, no dedicated user needed
2026-05-03 02:29:06 +00:00
9e42f32270 fix: remove sudo from apt commands and RestrictSUIDSGID from service
All checks were successful
CI/CD Pipeline / Code Format (push) Successful in 2s
CI/CD Pipeline / Clippy Lints (push) Successful in 1m17s
CI/CD Pipeline / Unit Tests (push) Successful in 56s
CI/CD Pipeline / Security Audit (push) Successful in 15s
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Successful in 1m57s
CI/CD Pipeline / Build Arch Package (push) Successful in 1m53s
CI/CD Pipeline / Build Alpine Package (push) Successful in 3m17s
CI/CD Pipeline / Build RPM Package (push) Successful in 3m36s
CI/CD Pipeline / Build Debian Package (push) Successful in 2m11s
- Remove sudo from apt command execution (service runs as root)
- Remove RestrictSUIDSGID from systemd service (blocks setuid for apt/dpkg)
- Remove NoNewPrivileges from systemd service (blocks sudo PERM_SUDOERS)
- Bump version to 0.3.2
2026-05-03 02:24:52 +00:00
2b35a143da fix: implement actual system reboot via shutdown/systemctl commands
All checks were successful
CI/CD Pipeline / Code Format (push) Successful in 2s
CI/CD Pipeline / Clippy Lints (push) Successful in 40s
CI/CD Pipeline / Unit Tests (push) Successful in 1m27s
CI/CD Pipeline / Security Audit (push) Successful in 4s
CI/CD Pipeline / Build Arch Package (push) Successful in 1m56s
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Successful in 2m32s
CI/CD Pipeline / Build Alpine Package (push) Successful in 3m25s
CI/CD Pipeline / Build RPM Package (push) Successful in 3m44s
CI/CD Pipeline / Build Debian Package (push) Successful in 3m0s
- Fix reboot_system() to use shutdown -r +N for delayed reboots
- Fix patches handler to call reboot_system() instead of just logging
- Add CAP_SYS_BOOT capability to systemd service for LXC reboot support
- Remove unused warn import from packages/mod.rs
- Bump version to 0.3.1
2026-05-03 01:37:22 +00:00
6f75ec4865 chore: bump version to 0.3.0 for beta release
Some checks failed
CI/CD Pipeline / Code Format (push) Successful in 2s
CI/CD Pipeline / Clippy Lints (push) Successful in 1m9s
CI/CD Pipeline / Unit Tests (push) Failing after 17s
CI/CD Pipeline / Build Debian Package (push) Has been skipped
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Has been skipped
CI/CD Pipeline / Build RPM Package (push) Has been skipped
CI/CD Pipeline / Build Alpine Package (push) Has been skipped
CI/CD Pipeline / Build Arch Package (push) Has been skipped
CI/CD Pipeline / Security Audit (push) Failing after 9s
2026-05-03 00:55:27 +00:00
a6cab4bbec style: fix import ordering in mtls.rs for cargo fmt compliance
All checks were successful
CI/CD Pipeline / Code Format (push) Successful in 1s
CI/CD Pipeline / Clippy Lints (push) Successful in 41s
CI/CD Pipeline / Unit Tests (push) Successful in 1m10s
CI/CD Pipeline / Security Audit (push) Successful in 5s
CI/CD Pipeline / Build Arch Package (push) Successful in 2m2s
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Successful in 1m57s
CI/CD Pipeline / Build Debian Package (push) Successful in 1m50s
CI/CD Pipeline / Build Alpine Package (push) Successful in 3m9s
CI/CD Pipeline / Build RPM Package (push) Successful in 3m13s
2026-05-03 00:40:11 +00:00
de9638e1b0 fix: resolve clippy errors for rustls 0.23 API and unnecessary_map_or lint
Some checks failed
CI/CD Pipeline / Code Format (push) Failing after 1s
CI/CD Pipeline / Clippy Lints (push) Successful in 37s
CI/CD Pipeline / Unit Tests (push) Successful in 48s
CI/CD Pipeline / Build Debian Package (push) Has been skipped
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Has been skipped
CI/CD Pipeline / Build RPM Package (push) Has been skipped
CI/CD Pipeline / Build Alpine Package (push) Has been skipped
CI/CD Pipeline / Build Arch Package (push) Has been skipped
CI/CD Pipeline / Security Audit (push) Successful in 4s
- Fix ServerConfig::builder() to builder_with_provider() for TLS 1.3 enforcement
- Add aws_lc_rs feature to rustls in Cargo.toml
- Fix clippy unnecessary_map_or -> is_some_and in packages/mod.rs
2026-05-03 00:36:32 +00:00
6d177c81a4 fix(ci): add apt-get -f install to resolve broken runner dependencies
Some checks failed
CI/CD Pipeline / Code Format (push) Successful in 2s
CI/CD Pipeline / Clippy Lints (push) Failing after 36s
CI/CD Pipeline / Unit Tests (push) Failing after 48s
CI/CD Pipeline / Build Debian Package (push) Has been skipped
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Has been skipped
CI/CD Pipeline / Build RPM Package (push) Has been skipped
CI/CD Pipeline / Build Alpine Package (push) Has been skipped
CI/CD Pipeline / Build Arch Package (push) Has been skipped
CI/CD Pipeline / Security Audit (push) Successful in 4s
Runners may have broken apt state from partial upgrades (e.g., openssh-client
version mismatch). Adding apt-get -f install before build deps ensures CI
works regardless of runner package state.
2026-05-03 00:31:13 +00:00
36890f65b1 style: fix cargo fmt compliance for mtls.rs closure and packages matches!
Some checks failed
CI/CD Pipeline / Code Format (push) Successful in 1s
CI/CD Pipeline / Clippy Lints (push) Failing after 3s
CI/CD Pipeline / Unit Tests (push) Failing after 2s
CI/CD Pipeline / Build Debian Package (push) Has been skipped
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Has been skipped
CI/CD Pipeline / Build RPM Package (push) Has been skipped
CI/CD Pipeline / Build Alpine Package (push) Has been skipped
CI/CD Pipeline / Build Arch Package (push) Has been skipped
CI/CD Pipeline / Security Audit (push) Failing after 2s
2026-05-02 21:52:39 +00:00
2ec8de961a style: fix mtls.rs indentation for cargo fmt compliance
Some checks failed
CI/CD Pipeline / Code Format (push) Failing after 1s
CI/CD Pipeline / Clippy Lints (push) Failing after 3s
CI/CD Pipeline / Unit Tests (push) Failing after 3s
CI/CD Pipeline / Build Debian Package (push) Has been skipped
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Has been skipped
CI/CD Pipeline / Build RPM Package (push) Has been skipped
CI/CD Pipeline / Build Alpine Package (push) Has been skipped
CI/CD Pipeline / Build Arch Package (push) Has been skipped
CI/CD Pipeline / Security Audit (push) Failing after 2s
2026-05-02 21:30:12 +00:00
03786d1798 v0.2.0: Fix List Jobs bug, TLS 1.3 enforcement, client_disconnect_timeout, RwLock contention
Some checks failed
CI/CD Pipeline / Code Format (push) Failing after 1s
CI/CD Pipeline / Clippy Lints (push) Failing after 2s
CI/CD Pipeline / Unit Tests (push) Failing after 7s
CI/CD Pipeline / Build Debian Package (push) Has been skipped
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Has been skipped
CI/CD Pipeline / Build RPM Package (push) Has been skipped
CI/CD Pipeline / Build Alpine Package (push) Has been skipped
CI/CD Pipeline / Build Arch Package (push) Has been skipped
CI/CD Pipeline / Security Audit (push) Failing after 3s
Bug fixes:
- Fix List Jobs connection reset: Add client_disconnect_timeout (5s) to prevent TLS write truncation
- Enforce TLS 1.3 only: Add with_protocol_versions(&[&TLS13]) to rustls ServerConfig
- Fix RwLock contention: Release read lock before sorting in list_jobs()
- Fix systemd service: Remove ProtectSystem=strict (blocks package management)
- Fix systemd service: Change Type=notify to Type=simple (fixes restart hangs)
- Fix systemd service: Add DEBIAN_FRONTEND=noninteractive
- Fix systemd service: Add ReadWritePaths for apt/dpkg paths

CI/CD:
- Add Ubuntu 22.04 build job to CI workflow

E2E Testing:
- Add comprehensive E2E test suite (test_e2e.py)
- Tests cover health, packages, patches, jobs, security, and reboot endpoints

Other:
- Bump version to 0.2.0
- Add lessons learned documentation
2026-05-02 20:59:02 +00:00
bda8d5c10c BUG-17: Strip release suffixes from package names in list_patches()
BUG-18: Add sudo prefix for apt install/upgrade/remove operations

- list_patches() now strips /noble-updates,noble-security suffixes
- run_apt() uses sudo for modifying operations (install, upgrade, etc.)
- Requires sudoers config for linux-patch-api user on agents
2026-04-30 22:55:02 +00:00
29 changed files with 1075 additions and 117 deletions

BIN
.a0proj/audit.db Normal file

Binary file not shown.

View File

@ -1 +1 @@
{"model_provider": "openai", "model_name": "BAAI/bge-m3"} {"model_provider": "ollama", "model_name": "bge-m3:latest"}

Binary file not shown.

View File

@ -1 +1 @@
8e95e0e8cec343042859ef1896dffae2d6bfba986fa2daeaf86600f62e39f71c 9cde4598eb68e4b1810cdf657333d8ca9e228ebcb4b4717524b62a61ae06f900

Binary file not shown.

View File

@ -1 +1 @@
{"/a0/usr/knowledge/main/echo-greeting.promptinclude.md": {"file": "/a0/usr/knowledge/main/echo-greeting.promptinclude.md", "checksum": "ad54de76e40288003564157a95ac89ef", "ids": ["qXFLuCv9Q9", "UjhNYB9CkP"]}, "/a0/usr/knowledge/main/Iran-US-Conflict-Update-2026-04-01.md": {"file": "/a0/usr/knowledge/main/Iran-US-Conflict-Update-2026-04-01.md", "checksum": "6beea9874c3bcb846d17f9a60c29d528", "ids": ["5sQkc0Ylqa", "FeZVPLWYss", "kYBRtDfHjJ"]}, "/a0/usr/knowledge/main/ollama-27b-modelfile.txt": {"file": "/a0/usr/knowledge/main/ollama-27b-modelfile.txt", "checksum": "3f4f724d6f777e0620df9781ebc82f36", "ids": ["yZoFOCA99D"]}, "/a0/usr/knowledge/main/behavioral-rules.md": {"file": "/a0/usr/knowledge/main/behavioral-rules.md", "checksum": "ff4230d5f02891487008864de55151e8", "ids": ["5LhBKVgUXB"]}, "/a0/usr/knowledge/main/utility_test.txt": {"file": "/a0/usr/knowledge/main/utility_test.txt", "checksum": "c8c29a129e935836a77048f47e231705", "ids": ["vrbKe4D4sR"]}, "/a0/usr/knowledge/main/welcome.md": {"file": "/a0/usr/knowledge/main/welcome.md", "checksum": "d947ce81d6dcc977a3ddf52e8d5e4712", "ids": ["0Qx7U1mSZH"]}, "/a0/usr/knowledge/main/capability_test_results.txt": {"file": "/a0/usr/knowledge/main/capability_test_results.txt", "checksum": "880b2a6e355125561f22e1f0ac38a3c4", "ids": ["hmVC8arGTg"]}, "/a0/usr/knowledge/main/Iran-US-Conflict-Analysis-2026.md": {"file": "/a0/usr/knowledge/main/Iran-US-Conflict-Analysis-2026.md", "checksum": "ffa6e16f560fc2c021df9c656e8dfdcc", "ids": ["WKKtg5Rj2e", "VBSDN1KENS"]}, "/a0/knowledge/main/tool_call_reference_examples.md": {"file": "/a0/knowledge/main/tool_call_reference_examples.md", "checksum": "1558e6e118619185e31224b1ed646b9a", "ids": ["mLgFu7vH7Z"]}, "/a0/knowledge/main/about/architecture.md": {"file": "/a0/knowledge/main/about/architecture.md", "checksum": "0de7a9280419982ef5fc98d0cc6ad2dc", "ids": ["VG5QHEdqZt", "oALIWNguyG"]}, "/a0/knowledge/main/about/configuration.md": {"file": "/a0/knowledge/main/about/configuration.md", "checksum": "9f83690fdca64631d063c75fd324d42c", "ids": ["XX5kcVMvDu", "T2B8pFL10O"]}, "/a0/knowledge/main/about/capabilities.md": {"file": "/a0/knowledge/main/about/capabilities.md", "checksum": "cf4d100df544af245940971464357e0b", "ids": ["S6MH1eLPzP", "laWnXkj3Ky"]}, "/a0/knowledge/main/about/identity.md": {"file": "/a0/knowledge/main/about/identity.md", "checksum": "63a2c83c6c3bf4c4008786c396618755", "ids": ["Yi3PLqGcaj"]}, "/a0/knowledge/main/about/setup-and-deployment.md": {"file": "/a0/knowledge/main/about/setup-and-deployment.md", "checksum": "3cf57d685f11a6989a73cf041c2018a3", "ids": ["KVJ5zsWDQX", "LoANN0xNbF"]}} {"/a0/usr/knowledge/main/Iran-US-Conflict-Update-2026-04-01.md": {"file": "/a0/usr/knowledge/main/Iran-US-Conflict-Update-2026-04-01.md", "checksum": "6beea9874c3bcb846d17f9a60c29d528", "ids": ["5sQkc0Ylqa", "FeZVPLWYss", "kYBRtDfHjJ"]}, "/a0/usr/knowledge/main/ollama-27b-modelfile.txt": {"file": "/a0/usr/knowledge/main/ollama-27b-modelfile.txt", "checksum": "3f4f724d6f777e0620df9781ebc82f36", "ids": ["yZoFOCA99D"]}, "/a0/usr/knowledge/main/behavioral-rules.md": {"file": "/a0/usr/knowledge/main/behavioral-rules.md", "checksum": "ff4230d5f02891487008864de55151e8", "ids": ["5LhBKVgUXB"]}, "/a0/usr/knowledge/main/utility_test.txt": {"file": "/a0/usr/knowledge/main/utility_test.txt", "checksum": "c8c29a129e935836a77048f47e231705", "ids": ["vrbKe4D4sR"]}, "/a0/usr/knowledge/main/welcome.md": {"file": "/a0/usr/knowledge/main/welcome.md", "checksum": "d947ce81d6dcc977a3ddf52e8d5e4712", "ids": ["0Qx7U1mSZH"]}, "/a0/usr/knowledge/main/capability_test_results.txt": {"file": "/a0/usr/knowledge/main/capability_test_results.txt", "checksum": "880b2a6e355125561f22e1f0ac38a3c4", "ids": ["hmVC8arGTg"]}, "/a0/usr/knowledge/main/Iran-US-Conflict-Analysis-2026.md": {"file": "/a0/usr/knowledge/main/Iran-US-Conflict-Analysis-2026.md", "checksum": "ffa6e16f560fc2c021df9c656e8dfdcc", "ids": ["WKKtg5Rj2e", "VBSDN1KENS"]}, "/a0/knowledge/main/tool_call_reference_examples.md": {"file": "/a0/knowledge/main/tool_call_reference_examples.md", "checksum": "1558e6e118619185e31224b1ed646b9a", "ids": ["mLgFu7vH7Z"]}, "/a0/knowledge/main/about/architecture.md": {"file": "/a0/knowledge/main/about/architecture.md", "checksum": "0de7a9280419982ef5fc98d0cc6ad2dc", "ids": ["VG5QHEdqZt", "oALIWNguyG"]}, "/a0/knowledge/main/about/configuration.md": {"file": "/a0/knowledge/main/about/configuration.md", "checksum": "9f83690fdca64631d063c75fd324d42c", "ids": ["XX5kcVMvDu", "T2B8pFL10O"]}, "/a0/knowledge/main/about/capabilities.md": {"file": "/a0/knowledge/main/about/capabilities.md", "checksum": "cf4d100df544af245940971464357e0b", "ids": ["S6MH1eLPzP", "laWnXkj3Ky"]}, "/a0/knowledge/main/about/identity.md": {"file": "/a0/knowledge/main/about/identity.md", "checksum": "63a2c83c6c3bf4c4008786c396618755", "ids": ["Yi3PLqGcaj"]}, "/a0/knowledge/main/about/setup-and-deployment.md": {"file": "/a0/knowledge/main/about/setup-and-deployment.md", "checksum": "3cf57d685f11a6989a73cf041c2018a3", "ids": ["KVJ5zsWDQX", "LoANN0xNbF"]}}

View File

@ -1,3 +1,3 @@
EMBEDDING_MODEL=BAAI/bge-m3 EMBEDDING_MODEL=bge-m3:latest
OLLAMA_HOST=http://ares.moon-dragon.us:11435 OLLAMA_HOST=http://ares.moon-dragon.us:11434
LLM_MODEL=qwen3.5:9b LLM_MODEL=qwen3.5:9b

View File

@ -3,7 +3,7 @@ name: CI/CD Pipeline
"on": "on":
push: push:
branches: [ master, develop ] branches: [ master, develop ]
tags: [ 'v*' ] tags: [ 'v*.*.*' ]
pull_request: pull_request:
branches: [ master ] branches: [ master ]
@ -48,6 +48,7 @@ jobs:
- name: Install system dependencies - name: Install system dependencies
run: | run: |
sudo apt-get update sudo apt-get update
sudo apt-get -f install -y
sudo apt-get install -y build-essential libsystemd-dev pkg-config sudo apt-get install -y build-essential libsystemd-dev pkg-config
- name: Run clippy - name: Run clippy
run: cargo clippy --all-targets --all-features -- -D warnings run: cargo clippy --all-targets --all-features -- -D warnings
@ -69,6 +70,7 @@ jobs:
- name: Install system dependencies - name: Install system dependencies
run: | run: |
sudo apt-get update sudo apt-get update
sudo apt-get -f install -y
sudo apt-get install -y build-essential libsystemd-dev pkg-config sudo apt-get install -y build-essential libsystemd-dev pkg-config
- name: Run tests - name: Run tests
run: cargo test --all-features run: cargo test --all-features
@ -90,6 +92,7 @@ jobs:
- name: Install system dependencies - name: Install system dependencies
run: | run: |
sudo apt-get update sudo apt-get update
sudo apt-get -f install -y
sudo apt-get install -y build-essential libsystemd-dev pkg-config sudo apt-get install -y build-essential libsystemd-dev pkg-config
- name: Run cargo-audit - name: Run cargo-audit
run: | run: |
@ -114,6 +117,7 @@ jobs:
- name: Install build dependencies - name: Install build dependencies
run: | run: |
sudo apt-get update sudo apt-get update
sudo apt-get -f install -y
sudo apt-get install -y build-essential debhelper pkg-config libsystemd-dev sudo apt-get install -y build-essential debhelper pkg-config libsystemd-dev
- name: Build Debian package - name: Build Debian package
run: | run: |
@ -128,6 +132,45 @@ jobs:
chmod +x scripts/upload-release.sh chmod +x scripts/upload-release.sh
./scripts/upload-release.sh "$TAG_NAME" "$FILE" ./scripts/upload-release.sh "$TAG_NAME" "$FILE"
build-deb-u2204:
name: Build Debian Package (Ubuntu 22.04)
needs: [fmt, clippy, test]
runs-on: ubuntu-22.04
steps:
- name: Checkout repository
run: |
curl -sfL -H "Authorization: token ${{ secrets.GITEATOKEN }}" "https://gitea-lxc.moon-dragon.us/echo/linux_patch_api/archive/${GITHUB_SHA}.tar.gz" -o repo.tar.gz
tar -xzf repo.tar.gz --strip-components=1
rm -f repo.tar.gz
- name: Install Rust
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable --profile minimal
. "$HOME/.cargo/env"
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- name: Install build dependencies
run: |
sudo apt-get update
sudo apt-get -f install -y
sudo apt-get install -y build-essential debhelper pkg-config libsystemd-dev
- name: Build Debian package
run: |
sudo dpkg-buildpackage -us -uc -b -d
- name: Upload to Gitea Release
if: startsWith(github.ref, 'refs/tags/')
env:
GITEA_TOKEN: ${{ secrets.GITEATOKEN }}
run: |
TAG_NAME=${GITHUB_REF#refs/tags/}
FILE=$(ls ../linux-patch-api_*.deb 2>/dev/null | head -1)
# Rename deb to include u2204 in filename to avoid collision with main build
if [ -n "$FILE" ]; then
U2204_FILE="$(echo "$FILE" | sed 's/_amd64/_u2204_amd64/')"
mv "$FILE" "$U2204_FILE"
FILE="$U2204_FILE"
fi
chmod +x scripts/upload-release.sh
./scripts/upload-release.sh "$TAG_NAME" "$FILE"
build-rpm: build-rpm:
name: Build RPM Package name: Build RPM Package
needs: [fmt, clippy, test] needs: [fmt, clippy, test]

2
Cargo.lock generated
View File

@ -1859,7 +1859,7 @@ dependencies = [
[[package]] [[package]]
name = "linux-patch-api" name = "linux-patch-api"
version = "0.1.0" version = "0.3.2"
dependencies = [ dependencies = [
"actix", "actix",
"actix-rt", "actix-rt",

View File

@ -1,6 +1,6 @@
[package] [package]
name = "linux-patch-api" name = "linux-patch-api"
version = "0.1.0" version = "0.3.5"
edition = "2021" edition = "2021"
authors = ["Echo <echo@moon-dragon.us>"] authors = ["Echo <echo@moon-dragon.us>"]
description = "Secure remote package management API for Linux systems" description = "Secure remote package management API for Linux systems"
@ -20,7 +20,7 @@ actix-tls = { version = "3", features = ["rustls-0_23"] }
tokio = { version = "1", features = ["full"] } tokio = { version = "1", features = ["full"] }
# TLS/mTLS (rustls for modern TLS 1.3) # TLS/mTLS (rustls for modern TLS 1.3)
rustls = "0.23" rustls = { version = "0.23", features = ["aws_lc_rs"] }
rustls-pemfile = "2" rustls-pemfile = "2"
tokio-rustls = "0.26" tokio-rustls = "0.26"
x509-parser = "0.16" x509-parser = "0.16"

View File

@ -5,7 +5,8 @@ After=network-online.target
Wants=network-online.target Wants=network-online.target
[Service] [Service]
Type=notify Type=simple
NotifyAccess=all
ExecStart=/usr/bin/linux-patch-api --config /etc/linux_patch_api/config.yaml ExecStart=/usr/bin/linux-patch-api --config /etc/linux_patch_api/config.yaml
Restart=on-failure Restart=on-failure
RestartSec=5s RestartSec=5s
@ -16,12 +17,17 @@ RuntimeDirectory=linux-patch-api
RuntimeDirectoryMode=0755 RuntimeDirectoryMode=0755
# Security hardening # Security hardening
NoNewPrivileges=true # NOTE: Package management requires extensive system access. The following
ProtectSystem=strict # restrictions have been removed because they block core functionality:
# - ProtectSystem=strict: Blocks writes to /usr, /etc, /lib where packages install
# - NoNewPrivileges: Blocks sudo/setuid which apt needs for _apt sandbox
# - RestrictSUIDSGID: Blocks setuid/setgid which apt needs for _apt sandbox
# - CapabilityBoundingSet: Drops capabilities that apt needs (SETUID, SETGID, CHOWN, etc.)
# - AmbientCapabilities: Same issue as CapabilityBoundingSet
# Network security is provided by mTLS + IP whitelist. The service runs as root
# and MUST be able to install/remove/update packages system-wide.
ProtectHome=true ProtectHome=true
ReadWritePaths=/var/lib/linux_patch_api /var/log/linux_patch_api
PrivateTmp=true PrivateTmp=true
PrivateDevices=true
ProtectHostname=true ProtectHostname=true
ProtectClock=true ProtectClock=true
ProtectKernelTunables=true ProtectKernelTunables=true
@ -31,8 +37,6 @@ RestrictNamespaces=true
LockPersonality=true LockPersonality=true
MemoryDenyWriteExecute=false MemoryDenyWriteExecute=false
RestrictRealtime=true RestrictRealtime=true
RestrictSUIDSGID=true
RemoveIPC=true
# System call filtering (whitelist approach) # System call filtering (whitelist approach)
SystemCallFilter=@system-service SystemCallFilter=@system-service
@ -40,6 +44,7 @@ SystemCallErrorNumber=EPERM
# Environment # Environment
Environment="RUST_BACKTRACE=1" Environment="RUST_BACKTRACE=1"
Environment="DEBIAN_FRONTEND=noninteractive"
Environment="RUST_LOG=info" Environment="RUST_LOG=info"
# Logging # Logging

50
debian/changelog vendored
View File

@ -1,11 +1,43 @@
linux-patch-api (1.0.0-1) stable; urgency=medium linux-patch-api (0.3.5-1) unstable; urgency=low
* Initial production release * Remove CapabilityBoundingSet and AmbientCapabilities - apt needs full root capabilities
* Secure mTLS-authenticated REST API for remote package management * Remove ProtectSystem=strict, NoNewPrivileges, RestrictSUIDSGID - block core functionality
* 15 API endpoints for package install/remove, patch application, system management * Remove ReadWritePaths - unnecessary without ProtectSystem=strict
* Asynchronous job processing with WebSocket status streaming * Fix E2E test: properly FAIL on status=failed package operations
* IP whitelist enforcement and comprehensive audit logging * Fix E2E test: require status=completed for install/update/remove lifecycle
* Systemd integration with security hardening * Update service file Type=notify -> Type=simple
* Supports Debian 11/12, Ubuntu 20.04/22.04/24.04 * Add DEBIAN_FRONTEND=noninteractive environment variable
-- Echo <echo@moon-dragon.us> Thu, 09 Apr 2026 18:57:12 -0500 -- Echo <echo@moon-dragon.us> Sat, 03 May 2026 03:15:00 -0500
linux-patch-api (0.3.4-1) unstable; urgency=low
* Fix CI workflow: prevent recursive tag triggers (v* -> v*.*.*)
* Fix CI workflow: upload u2204 deb to same release (no -u2204 suffix)
* Remove sudo from apt commands (service runs as root)
* Remove NoNewPrivileges and RestrictSUIDSGID from service file
* Update service file Type=notify -> Type=simple
* Add DEBIAN_FRONTEND=noninteractive environment variable
-- Echo <echo@moon-dragon.us> Fri, 02 May 2026 22:00:00 -0500
linux-patch-api (0.3.3-1) unstable; urgency=low
* Fix dpkg packaging: remove linux-patch-api user creation
* Change ownership to root:root in preinst/postinst scripts
* Bump version to 0.3.3
-- Echo <echo@moon-dragon.us> Fri, 02 May 2026 21:45:00 -0500
linux-patch-api (0.3.2-1) unstable; urgency=low
* Remove sudo from apt commands in source code
* Remove NoNewPrivileges=true from service file
* Remove RestrictSUIDSGID=true from service file
* Add DEBIAN_FRONTEND=noninteractive to service file
* Fix TLS 1.3 enforcement in mtls.rs
* Add client_disconnect_timeout to main.rs
* Optimize RwLock usage in jobs/manager.rs
* Bump version to 0.3.2
-- Echo <echo@moon-dragon.us> Fri, 02 May 2026 21:30:00 -0500

View File

@ -13,14 +13,14 @@ if [ "$1" = "configure" ]; then
echo "Creating default config.yaml..." echo "Creating default config.yaml..."
cp /etc/linux_patch_api/config.yaml.example /etc/linux_patch_api/config.yaml cp /etc/linux_patch_api/config.yaml.example /etc/linux_patch_api/config.yaml
chmod 640 /etc/linux_patch_api/config.yaml chmod 640 /etc/linux_patch_api/config.yaml
chown linux-patch-api:linux-patch-api /etc/linux_patch_api/config.yaml chown root:root /etc/linux_patch_api/config.yaml
fi fi
if [ ! -f "/etc/linux_patch_api/whitelist.yaml" ]; then if [ ! -f "/etc/linux_patch_api/whitelist.yaml" ]; then
echo "Creating default whitelist.yaml..." echo "Creating default whitelist.yaml..."
cp /etc/linux_patch_api/whitelist.yaml.example /etc/linux_patch_api/whitelist.yaml cp /etc/linux_patch_api/whitelist.yaml.example /etc/linux_patch_api/whitelist.yaml
chmod 640 /etc/linux_patch_api/whitelist.yaml chmod 640 /etc/linux_patch_api/whitelist.yaml
chown linux-patch-api:linux-patch-api /etc/linux_patch_api/whitelist.yaml chown root:root /etc/linux_patch_api/whitelist.yaml
fi fi
# Reload systemd daemon to pick up new service file # Reload systemd daemon to pick up new service file

View File

@ -39,18 +39,6 @@ if [ "$1" = "purge" ]; then
rm -rf /var/log/linux_patch_api rm -rf /var/log/linux_patch_api
fi fi
# Remove system user
if getent passwd linux-patch-api > /dev/null 2>&1; then
echo "Removing user linux-patch-api..."
userdel linux-patch-api 2>/dev/null || true
fi
# Remove system group
if getent group linux-patch-api > /dev/null 2>&1; then
echo "Removing group linux-patch-api..."
groupdel linux-patch-api 2>/dev/null || true
fi
echo "linux-patch-api purged successfully" echo "linux-patch-api purged successfully"
fi fi

View File

@ -9,31 +9,14 @@ if [ -d "/etc/linux_patch_api" ]; then
echo "Detected existing installation - performing upgrade" echo "Detected existing installation - performing upgrade"
fi fi
# Create system user if it doesn't exist
if ! getent group linux-patch-api > /dev/null 2>&1; then
echo "Creating group linux-patch-api..."
groupadd --system linux-patch-api
fi
if ! getent passwd linux-patch-api > /dev/null 2>&1; then
echo "Creating user linux-patch-api..."
useradd --system \
--gid linux-patch-api \
--home-dir /var/lib/linux_patch_api \
--no-create-home \
--shell /usr/sbin/nologin \
--comment "Linux Patch API Service" \
linux-patch-api
fi
# Create required directories # Create required directories
mkdir -p /etc/linux_patch_api/certs mkdir -p /etc/linux_patch_api/certs
mkdir -p /var/lib/linux_patch_api mkdir -p /var/lib/linux_patch_api
mkdir -p /var/log/linux_patch_api mkdir -p /var/log/linux_patch_api
# Set proper ownership # Set proper ownership (service runs as root)
chown -R linux-patch-api:linux-patch-api /var/lib/linux_patch_api chown -R root:root /var/lib/linux_patch_api
chown -R linux-patch-api:linux-patch-api /var/log/linux_patch_api chown -R root:root /var/log/linux_patch_api
# Set secure permissions # Set secure permissions
chmod 750 /etc/linux_patch_api chmod 750 /etc/linux_patch_api

View File

@ -5,7 +5,8 @@ After=network-online.target
Wants=network-online.target Wants=network-online.target
[Service] [Service]
Type=notify Type=simple
NotifyAccess=all
ExecStart=/usr/bin/linux-patch-api --config /etc/linux_patch_api/config.yaml ExecStart=/usr/bin/linux-patch-api --config /etc/linux_patch_api/config.yaml
Restart=on-failure Restart=on-failure
RestartSec=5s RestartSec=5s
@ -16,12 +17,17 @@ RuntimeDirectory=linux-patch-api
RuntimeDirectoryMode=0755 RuntimeDirectoryMode=0755
# Security hardening # Security hardening
NoNewPrivileges=true # NOTE: Package management requires extensive system access. The following
ProtectSystem=strict # restrictions have been removed because they block core functionality:
# - ProtectSystem=strict: Blocks writes to /usr, /etc, /lib where packages install
# - NoNewPrivileges: Blocks sudo/setuid which apt needs for _apt sandbox
# - RestrictSUIDSGID: Blocks setuid/setgid which apt needs for _apt sandbox
# - CapabilityBoundingSet: Drops capabilities that apt needs (SETUID, SETGID, CHOWN, etc.)
# - AmbientCapabilities: Same issue as CapabilityBoundingSet
# Network security is provided by mTLS + IP whitelist. The service runs as root
# and MUST be able to install/remove/update packages system-wide.
ProtectHome=true ProtectHome=true
ReadWritePaths=/var/lib/linux_patch_api /var/log/linux_patch_api
PrivateTmp=true PrivateTmp=true
PrivateDevices=true
ProtectHostname=true ProtectHostname=true
ProtectClock=true ProtectClock=true
ProtectKernelTunables=true ProtectKernelTunables=true
@ -31,8 +37,6 @@ RestrictNamespaces=true
LockPersonality=true LockPersonality=true
MemoryDenyWriteExecute=false MemoryDenyWriteExecute=false
RestrictRealtime=true RestrictRealtime=true
RestrictSUIDSGID=true
RemoveIPC=true
# System call filtering (whitelist approach) # System call filtering (whitelist approach)
SystemCallFilter=@system-service SystemCallFilter=@system-service
@ -40,6 +44,7 @@ SystemCallErrorNumber=EPERM
# Environment # Environment
Environment="RUST_BACKTRACE=1" Environment="RUST_BACKTRACE=1"
Environment="DEBIAN_FRONTEND=noninteractive"
Environment="RUST_LOG=info" Environment="RUST_LOG=info"
# Logging # Logging

4
debian/postinst vendored
View File

@ -13,14 +13,14 @@ if [ "$1" = "configure" ]; then
echo "Creating default config.yaml..." echo "Creating default config.yaml..."
cp /etc/linux_patch_api/config.yaml.example /etc/linux_patch_api/config.yaml cp /etc/linux_patch_api/config.yaml.example /etc/linux_patch_api/config.yaml
chmod 640 /etc/linux_patch_api/config.yaml chmod 640 /etc/linux_patch_api/config.yaml
chown linux-patch-api:linux-patch-api /etc/linux_patch_api/config.yaml chown root:root /etc/linux_patch_api/config.yaml
fi fi
if [ ! -f "/etc/linux_patch_api/whitelist.yaml" ]; then if [ ! -f "/etc/linux_patch_api/whitelist.yaml" ]; then
echo "Creating default whitelist.yaml..." echo "Creating default whitelist.yaml..."
cp /etc/linux_patch_api/whitelist.yaml.example /etc/linux_patch_api/whitelist.yaml cp /etc/linux_patch_api/whitelist.yaml.example /etc/linux_patch_api/whitelist.yaml
chmod 640 /etc/linux_patch_api/whitelist.yaml chmod 640 /etc/linux_patch_api/whitelist.yaml
chown linux-patch-api:linux-patch-api /etc/linux_patch_api/whitelist.yaml chown root:root /etc/linux_patch_api/whitelist.yaml
fi fi
# Reload systemd daemon to pick up new service file # Reload systemd daemon to pick up new service file

12
debian/postrm vendored
View File

@ -39,18 +39,6 @@ if [ "$1" = "purge" ]; then
rm -rf /var/log/linux_patch_api rm -rf /var/log/linux_patch_api
fi fi
# Remove system user
if getent passwd linux-patch-api > /dev/null 2>&1; then
echo "Removing user linux-patch-api..."
userdel linux-patch-api 2>/dev/null || true
fi
# Remove system group
if getent group linux-patch-api > /dev/null 2>&1; then
echo "Removing group linux-patch-api..."
groupdel linux-patch-api 2>/dev/null || true
fi
echo "linux-patch-api purged successfully" echo "linux-patch-api purged successfully"
fi fi

23
debian/preinst vendored
View File

@ -9,31 +9,14 @@ if [ -d "/etc/linux_patch_api" ]; then
echo "Detected existing installation - performing upgrade" echo "Detected existing installation - performing upgrade"
fi fi
# Create system user if it doesn't exist
if ! getent group linux-patch-api > /dev/null 2>&1; then
echo "Creating group linux-patch-api..."
groupadd --system linux-patch-api
fi
if ! getent passwd linux-patch-api > /dev/null 2>&1; then
echo "Creating user linux-patch-api..."
useradd --system \
--gid linux-patch-api \
--home-dir /var/lib/linux_patch_api \
--no-create-home \
--shell /usr/sbin/nologin \
--comment "Linux Patch API Service" \
linux-patch-api
fi
# Create required directories # Create required directories
mkdir -p /etc/linux_patch_api/certs mkdir -p /etc/linux_patch_api/certs
mkdir -p /var/lib/linux_patch_api mkdir -p /var/lib/linux_patch_api
mkdir -p /var/log/linux_patch_api mkdir -p /var/log/linux_patch_api
# Set proper ownership # Set proper ownership (service runs as root)
chown -R linux-patch-api:linux-patch-api /var/lib/linux_patch_api chown -R root:root /var/lib/linux_patch_api
chown -R linux-patch-api:linux-patch-api /var/log/linux_patch_api chown -R root:root /var/log/linux_patch_api
# Set secure permissions # Set secure permissions
chmod 750 /etc/linux_patch_api chmod 750 /etc/linux_patch_api

View File

@ -139,7 +139,22 @@ pub async fn apply_patches(
), ),
) )
.await; .await;
// In production, would trigger actual reboot via system handler // Trigger actual reboot via system handler
match backend_clone.reboot_system(request.reboot_delay_seconds) {
Ok(_) => {
let _ = job_manager_clone
.add_job_log(
&job_id_clone,
"Reboot command executed".to_string(),
)
.await;
}
Err(e) => {
let _ = job_manager_clone
.add_job_log(&job_id_clone, format!("Reboot failed: {}", e))
.await;
}
}
} }
} }
Err(e) => { Err(e) => {

View File

@ -11,7 +11,9 @@ use actix_web::{
use chrono::{DateTime, Duration, Utc}; use chrono::{DateTime, Duration, Utc};
use futures_util::future::LocalBoxFuture; use futures_util::future::LocalBoxFuture;
use rustls::{ use rustls::{
crypto::aws_lc_rs,
server::{ServerConfig, WebPkiClientVerifier}, server::{ServerConfig, WebPkiClientVerifier},
version::TLS13,
RootCertStore, RootCertStore,
}; };
use rustls_pemfile::{certs, private_key}; use rustls_pemfile::{certs, private_key};
@ -78,7 +80,11 @@ impl MtlsMiddleware {
let server_cert = load_certs(&self.config.server_cert_path)?; let server_cert = load_certs(&self.config.server_cert_path)?;
let server_key = load_private_key(&self.config.server_key_path)?; let server_key = load_private_key(&self.config.server_key_path)?;
let config = ServerConfig::builder() let config = ServerConfig::builder_with_provider(Arc::new(aws_lc_rs::default_provider()))
.with_protocol_versions(&[&TLS13])
.map_err(|e| {
MtlsError::ServerConfigError(format!("Failed to set TLS 1.3 only: {}", e))
})?
.with_client_cert_verifier(client_verifier) .with_client_cert_verifier(client_verifier)
.with_single_cert(server_cert, server_key) .with_single_cert(server_cert, server_key)
.map_err(|e| MtlsError::ServerConfigError(e.to_string()))?; .map_err(|e| MtlsError::ServerConfigError(e.to_string()))?;

View File

@ -213,8 +213,11 @@ impl JobManager {
/// List all jobs with optional status filter /// List all jobs with optional status filter
pub async fn list_jobs(&self, status_filter: Option<JobStatus>, limit: usize) -> Vec<Job> { pub async fn list_jobs(&self, status_filter: Option<JobStatus>, limit: usize) -> Vec<Job> {
let jobs = self.jobs.read().await; // FIX: Clone under lock, then release before sorting to reduce lock contention
let mut result: Vec<Job> = jobs.values().cloned().collect(); let mut result = {
let jobs = self.jobs.read().await;
jobs.values().cloned().collect::<Vec<Job>>()
}; // Lock released here
// Filter by status if provided // Filter by status if provided
if let Some(status) = status_filter { if let Some(status) = status_filter {

View File

@ -141,6 +141,8 @@ async fn main() -> Result<()> {
.workers(4) .workers(4)
// VULN-004: Configure header size limit to 8KB to prevent DoS via oversized headers // VULN-004: Configure header size limit to 8KB to prevent DoS via oversized headers
.client_request_timeout(std::time::Duration::from_secs(5)) .client_request_timeout(std::time::Duration::from_secs(5))
// FIX: Set explicit client disconnect timeout to prevent connection resets on larger responses
.client_disconnect_timeout(std::time::Duration::from_secs(5))
.keep_alive(std::time::Duration::from_secs(15)) .keep_alive(std::time::Duration::from_secs(15))
.max_connection_rate(1000); .max_connection_rate(1000);
info!( info!(

View File

@ -6,7 +6,7 @@
use anyhow::{Context, Result}; use anyhow::{Context, Result};
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use std::process::Command; use std::process::Command;
use tracing::{info, warn}; use tracing::info;
/// Package status /// Package status
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)] #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
@ -98,8 +98,12 @@ impl AptBackend {
/// Run apt command and capture output /// Run apt command and capture output
fn run_apt(&self, args: &[&str]) -> Result<String> { fn run_apt(&self, args: &[&str]) -> Result<String> {
let output = Command::new("apt") // Service runs as root - no sudo needed for apt commands
.args(args) let program = "apt";
let cmd_args: Vec<&str> = args.to_vec();
let output = Command::new(program)
.args(&cmd_args)
.output() .output()
.context("Failed to execute apt command")?; .context("Failed to execute apt command")?;
@ -330,7 +334,8 @@ impl PackageManagerBackend for AptBackend {
for line in output.lines() { for line in output.lines() {
let parts: Vec<&str> = line.split_whitespace().collect(); let parts: Vec<&str> = line.split_whitespace().collect();
if parts.len() >= 3 { if parts.len() >= 3 {
let name = parts[0].to_string(); // Strip release suffix from package name (e.g., "pkg/noble-updates,noble-security" → "pkg")
let name = parts[0].split('/').next().unwrap_or(parts[0]).to_string();
let current_version = parts[1].to_string(); let current_version = parts[1].to_string();
let available_version = parts[2].to_string(); let available_version = parts[2].to_string();
@ -452,17 +457,27 @@ impl PackageManagerBackend for AptBackend {
fn reboot_system(&self, delay_seconds: u64) -> Result<()> { fn reboot_system(&self, delay_seconds: u64) -> Result<()> {
if delay_seconds > 0 { if delay_seconds > 0 {
info!("Scheduling reboot in {} seconds", delay_seconds); // Use shutdown command for delayed reboot (converts seconds to minutes, minimum 1)
// In production, would use systemd shutdown scheduler let delay_minutes = std::cmp::max(1u64, delay_seconds.div_ceil(60));
warn!("Delayed reboot not fully implemented - would use systemd in production"); info!(
"Scheduling system reboot in {} minutes (requested {} seconds)",
delay_minutes, delay_seconds
);
Command::new("shutdown")
.args(["-r", &format!("+{}", delay_minutes)])
.status()
.context("Failed to schedule delayed reboot")?;
info!("System reboot scheduled in {} minutes", delay_minutes);
} else {
// Immediate reboot using systemctl
info!("Initiating immediate system reboot");
Command::new("systemctl")
.arg("reboot")
.status()
.context("Failed to execute reboot command")?;
info!("System reboot initiated");
} }
Command::new("systemctl")
.arg("reboot")
.status()
.context("Failed to execute reboot command")?;
info!("System reboot initiated");
Ok(()) Ok(())
} }
} }

73
tasks/lessons.md Normal file
View File

@ -0,0 +1,73 @@
# Lessons Learned
## 2026-05-02 - Infrastructure Host Protection (CRITICAL)
**Mistake:** Attempted to install Rust and system packages on ares (Docker GPU host) without explicit approval.
**Correction:** Kelly explicitly stated: "Ares and MoonProx13 are docker and LXC hosts... YOU WILL NEVER install anything on them without explicit approval. I do not want them touched." and "Building all binaries happens through the CI/CD workflow and is done by the Gitea Runner actors. That is the only approved route."
**Rule:** NEVER install packages or make system-level changes on ares or moonprox13 without explicit approval. NEVER build binaries locally or on dev/runners - use CI/CD ONLY.
**Status:** Active
## 2026-05-02 - Systemd ProtectSystem=strict blocks package management
**Mistake:** Deployed service with ProtectSystem=strict which prevented apt/dpkg from writing to filesystem.
**Correction:** Removed ProtectSystem=strict since package management requires write access to /usr, /etc, /lib. Network security is provided by mTLS + IP whitelist.
**Rule:** For package management services, do not use ProtectSystem=strict. Use mTLS + IP whitelist for security instead.
**Status:** Active
## 2026-05-02 - Systemd ReadWritePaths must reference existing directories
**Mistake:** Added non-existent paths (e.g., /usr/lib/apk/db for Alpine) to ReadWritePaths, causing service startup failure.
**Correction:** Only include paths that exist on the target system. For Ubuntu, only include apt/dpkg paths.
**Rule:** Always verify paths exist on target systems before adding to ReadWritePaths.
**Status:** Active
## 2026-05-02 - Type=notify requires sd_notify() from binary
**Mistake:** Service used Type=notify but binary didn't call sd_notify(), causing restart hangs and 'activating' status.
**Correction:** Changed to Type=simple with NotifyAccess=all.
**Rule:** Use Type=simple unless the binary explicitly calls sd_notify().
**Status:** Active
## 2026-05-02 - Binary version mismatch between LXCs
**Mistake:** Assumed all LXCs had the same binary version. Dev/u2404 had older Apr 9 build while u2204 had newer Apr 30 build.
**Correction:** Always verify binary versions match before testing. Different BuildIDs mean different code.
**Rule:** Check binary versions (file size, BuildID, --version output) on all target systems before testing.
**Status:** Active
## 2026-05-02 - Always run cargo fmt AND cargo clippy locally before pushing
**Mistake:** Pushed code changes without running cargo fmt and cargo clippy locally, causing 8 CI iterations to fix formatting and lint errors.
**Correction:** Run `cargo fmt --all -- --check` and `cargo clippy --all-targets --all-features -- -D warnings` locally before every push.
**Rule:** ALWAYS run cargo fmt AND cargo clippy locally before pushing to Gitea. Fix all errors before pushing.
**Status:** Active
## 2026-05-02 - rustls 0.23 API: builder() vs builder_with_provider()
**Mistake:** Used ServerConfig::builder() which returns WantsVerifier state, then called with_protocol_versions() which requires WantsVersions state.
**Correction:** Use ServerConfig::builder_with_provider(Arc::new(aws_lc_rs::default_provider())) to get WantsVersions state. Also need aws_lc_rs feature in Cargo.toml.
**Rule:** In rustls 0.23, to set protocol versions, use builder_with_provider() not builder(). The builder() shortcut skips version negotiation.
**Status:** Active
## 2026-05-02 - apt broken deps block unrelated package installs
**Mistake:** CI failed because openssh-server on runner had version mismatch (13.16 server vs 13.15 client), blocking all apt-get install operations.
**Correction:** Add `sudo apt-get -f install -y` before `sudo apt-get install` in CI workflow to fix broken deps automatically.
**Rule:** Always add `apt-get -f install -y` before `apt-get install` in CI workflows. Runners may have broken apt state from partial upgrades.
**Status:** Active
## 2026-05-03 - NoNewPrivileges=true blocks sudo in systemd services
**Mistake:** Service used NoNewPrivileges=true which prevented sudo from working (PERM_SUDOERS: setresuid Operation not permitted).
**Correction:** Removed NoNewPrivileges=true from systemd service. The service runs as root and uses sudo for apt commands, which requires privilege escalation capabilities.
**Rule:** For package management services that use sudo, do not use NoNewPrivileges=true. mTLS + IP whitelist provides network security.
**Status:** Active
## 2026-05-03 - RestrictSUIDSGID=true blocks sudo in systemd services
**Mistake:** Service used RestrictSUIDSGID=true which prevented sudo from using setuid/setgid operations.
**Correction:** Removed RestrictSUIDSGID=true from systemd service. Package management requires setuid/setgid for apt/dpkg.
**Rule:** For package management services, do not use RestrictSUIDSGID=true. It blocks sudo and apt from working.
**Status:** Active
## 2026-05-03 - dpkg preinst creates linux-patch-api user causing permission issues
**Mistake:** dpkg preinst script creates a linux-patch-api system user and changes directory ownership, causing the service to crash with 'Permission denied' on log file creation.
**Correction:** Fix dpkg preinst to not create the linux-patch-api user or change directory ownership. Service runs as root and directories should be owned by root.
**Rule:** For services that run as root, do not create a dedicated system user in the dpkg preinst script. Keep all directory ownership as root:root.
**Status:** Active
## 2026-05-03 - Service runs as root, no sudo needed for apt commands
**Mistake:** Service used sudo to run apt commands even though it runs as root. This caused failures when systemd security restrictions blocked sudo.
**Correction:** Removed sudo from apt command execution in the source code. Service runs as root and can execute apt directly.
**Rule:** If a service runs as root, it does not need sudo to execute commands. Remove sudo from command execution.
**Status:** Active

12
tests/e2e/certs/ca.crt Normal file
View File

@ -0,0 +1,12 @@
-----BEGIN CERTIFICATE-----
MIIBsjCCAVigAwIBAgIRALf8Fb/3Ywf0MPuZsilmqEQwCgYIKoZIzj0EAwIwODEe
MBwGA1UEAwwVUGF0Y2ggTWFuYWdlciBSb290IENBMRYwFAYDVQQKDA1QYXRjaCBN
YW5hZ2VyMB4XDTI2MDQyODIzMzE1N1oXDTM2MDQyNTIzMzE1N1owODEeMBwGA1UE
AwwVUGF0Y2ggTWFuYWdlciBSb290IENBMRYwFAYDVQQKDA1QYXRjaCBNYW5hZ2Vy
MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAETxO5hS6lUm9XGGDyFB2fx/vnFoV0
Hexza1p4g1YcLN0ZpuzVbMgpXHO4Izak1vkbK1FwDSkjwNslNTRaXDpDI6NDMEEw
DwYDVR0PAQH/BAUDAwcGADAdBgNVHQ4EFgQUAFyt+OCZbIlrCUs9w8TzZUnWT/Mw
DwYDVR0TAQH/BAUwAwEB/zAKBggqhkjOPQQDAgNIADBFAiBAI+ZIoGXrnxBPi9tG
1ByGdLvugBcJYppAh5rMnhCygwIhANzZPcPxa4rvY5knNnOlAasQC+/a63C/4nz0
mNULyLoW
-----END CERTIFICATE-----

View File

@ -0,0 +1,12 @@
-----BEGIN CERTIFICATE-----
MIIBvjCCAWWgAwIBAgIQe4AusxcxVN4ff3foapGUvzAKBggqhkjOPQQDAjA4MR4w
HAYDVQQDDBVQYXRjaCBNYW5hZ2VyIFJvb3QgQ0ExFjAUBgNVBAoMDVBhdGNoIE1h
bmFnZXIwHhcNMjYwNDI5MDAxNzUyWhcNMjcwNDI5MDAxNzUyWjAxMS8wLQYDVQQD
DCZsaW51eC1wYXRjaC1tYW5hZ2VyLWRldi5tb29uLWRyYWdvbi51czBZMBMGByqG
SM49AgEGCCqGSM49AwEHA0IABPxfVZRYTnaX+LYjcyaVKI+CsRIQnZEjoIm9XaEc
qKtj7Altqcff1vV5tbxv5bd+6EQc9oUVyk8USc+uID7Fa9OjWDBWMA8GA1UdDwEB
/wQFAwMHgAAwEwYDVR0lBAwwCgYIKwYBBQUHAwIwHQYDVR0OBBYEFFBsIi4VRUcR
DS7eHcRzgrflHL1VMA8GA1UdEwEB/wQFMAMBAQAwCgYIKoZIzj0EAwIDRwAwRAIg
cn5uK0MHBkmxciBiSzRoRF4XdOLYcZNK/JvAxqw4FTECIGNuVL62Y381bonC96oj
fdSeIoAQJsk2rt1wgR0/Zx5D
-----END CERTIFICATE-----

View File

@ -0,0 +1,5 @@
-----BEGIN PRIVATE KEY-----
MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQg5dkQDY44tZkcnQ6M
lGDNFyFrEvcOlnDoKfA/uTvBCtehRANCAAT8X1WUWE52l/i2I3MmlSiPgrESEJ2R
I6CJvV2hHKirY+wJbanH39b1ebW8b+W3fuhEHPaFFcpPFEnPriA+xWvT
-----END PRIVATE KEY-----

788
tests/e2e/test_e2e.py Normal file
View File

@ -0,0 +1,788 @@
#!/usr/bin/env python3
"""
Linux Patch API - End-to-End Test Suite
Comprehensive E2E tests against deployed API instances on 3 LXCs:
- linux-patch-manager-dev (192.168.0.247)
- gitea-runner-u2204 (192.168.2.232)
- gitea-runner-u2404 (192.168.3.180)
Uses mTLS with deployed Patch Manager Root CA certificates.
Reboot test runs LAST after all other tests pass.
Usage:
python3 test_e2e.py [--target all|dev|u2204|u2404] [--skip-reboot] [--verbose]
"""
import argparse
import json
import sys
import time
from dataclasses import dataclass, field
from pathlib import Path
from typing import Optional
import requests
import urllib3
# Suppress insecure warnings for self-signed CA
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
# =============================================================================
# Configuration
# =============================================================================
CERTS_DIR = Path(__file__).parent / "certs"
CA_CERT = CERTS_DIR / "ca.crt"
CLIENT_CERT = CERTS_DIR / "client.crt"
CLIENT_KEY = CERTS_DIR / "client.key"
TARGETS = {
"dev": {
"name": "linux-patch-manager-dev",
"host": "192.168.0.247",
"port": 12443,
"os": "Debian/Ubuntu (dev)",
},
"u2204": {
"name": "gitea-runner-u2204",
"host": "192.168.2.232",
"port": 12443,
"os": "Ubuntu 22.04",
},
"u2404": {
"name": "gitea-runner-u2404",
"host": "192.168.3.180",
"port": 12443,
"os": "Ubuntu 24.04",
},
}
# Safe test package - small, harmless, easy to install/remove
TEST_PACKAGE = "hello"
# Job polling settings
JOB_POLL_INTERVAL = 2 # seconds
JOB_POLL_TIMEOUT = 300 # 5 minutes max
# =============================================================================
# Test Result Tracking
# =============================================================================
@dataclass
class TestResult:
name: str
passed: bool
message: str = ""
duration_ms: float = 0
details: dict = field(default_factory=dict)
@dataclass
class TargetResults:
target_name: str
target_host: str
results: list = field(default_factory=list)
passed: int = 0
failed: int = 0
skipped: int = 0
errors: int = 0
@property
def total(self):
return self.passed + self.failed + self.skipped + self.errors
# =============================================================================
# API Client
# =============================================================================
class PatchAPIClient:
"""mTLS client for the Linux Patch API."""
def __init__(self, host: str, port: int = 12443, timeout: int = 60):
self.base_url = f"https://{host}:{port}"
self.host = host
self.port = port
self.timeout = timeout
self.session = requests.Session()
self.session.cert = (str(CLIENT_CERT), str(CLIENT_KEY))
# Suppress InsecureRequestWarning for self-signed CA
self.session.verify = False
def _request(self, method: str, path: str, **kwargs) -> requests.Response:
url = f"{self.base_url}{path}"
timeout = kwargs.pop("timeout", self.timeout)
return self.session.request(method, url, timeout=timeout, **kwargs)
def get(self, path: str, **kwargs) -> requests.Response:
return self._request("GET", path, **kwargs)
def post(self, path: str, **kwargs) -> requests.Response:
return self._request("POST", path, **kwargs)
def put(self, path: str, **kwargs) -> requests.Response:
return self._request("PUT", path, **kwargs)
def delete(self, path: str, **kwargs) -> requests.Response:
return self._request("DELETE", path, **kwargs)
def close(self):
self.session.close()
# =============================================================================
# Helper Functions
# =============================================================================
def validate_envelope(data: dict, test_name: str) -> Optional[str]:
"""Validate standard response envelope. Returns error message or None."""
required_fields = ["success", "request_id", "timestamp", "data", "error"]
for f in required_fields:
if f not in data:
return f"Missing required field: {f}"
if not isinstance(data["success"], bool):
return f"'success' should be boolean, got {type(data['success']).__name__}"
if not isinstance(data["request_id"], str):
return f"'request_id' should be string, got {type(data['request_id']).__name__}"
if not isinstance(data["timestamp"], str):
return f"'timestamp' should be string, got {type(data['timestamp']).__name__}"
return None
def poll_job(client: PatchAPIClient, job_id: str, timeout: int = JOB_POLL_TIMEOUT) -> dict:
"""Poll a job until completion or timeout. Returns final job data."""
start = time.time()
while time.time() - start < timeout:
resp = client.get(f"/api/v1/jobs/{job_id}")
if resp.status_code != 200:
raise Exception(f"Job poll failed: HTTP {resp.status_code} - {resp.text}")
data = resp.json()
if data.get("success") and data.get("data", {}).get("status") in [
"completed",
"failed",
"cancelled",
"timeout",
]:
return data["data"]
time.sleep(JOB_POLL_INTERVAL)
raise Exception(f"Job {job_id} timed out after {timeout}s")
def run_test(
results: TargetResults,
name: str,
func,
client: PatchAPIClient,
skip: bool = False,
**kwargs,
) -> TestResult:
"""Run a single test and record results."""
if skip:
result = TestResult(name=name, passed=False, message="SKIPPED")
results.skipped += 1
results.results.append(result)
return result
start = time.time()
try:
msg = func(client, **kwargs)
elapsed = (time.time() - start) * 1000
result = TestResult(
name=name, passed=True, message=msg or "PASS", duration_ms=elapsed
)
results.passed += 1
except AssertionError as e:
elapsed = (time.time() - start) * 1000
result = TestResult(
name=name, passed=False, message=f"FAIL: {e}", duration_ms=elapsed
)
results.failed += 1
except Exception as e:
elapsed = (time.time() - start) * 1000
result = TestResult(
name=name, passed=False, message=f"ERROR: {e}", duration_ms=elapsed
)
results.errors += 1
results.results.append(result)
return result
# =============================================================================
# Test Functions
# =============================================================================
def test_health_endpoint(client: PatchAPIClient) -> str:
"""GET /health - Verify health check returns healthy status."""
resp = client.get("/health")
assert resp.status_code == 200, f"Expected 200, got {resp.status_code}"
data = resp.json()
err = validate_envelope(data, "health")
assert err is None, f"Envelope validation failed: {err}"
assert data["success"] is True, f"Expected success=true, got {data['success']}"
assert data["data"]["status"] == "healthy", f"Expected status=healthy, got {data['data']['status']}"
assert "version" in data["data"], "Missing version in health response"
assert "uptime_seconds" in data["data"], "Missing uptime_seconds in health response"
return f"Health OK: status={data['data']['status']}, version={data['data']['version']}, uptime={data['data']['uptime_seconds']}s"
def test_system_info(client: PatchAPIClient) -> str:
"""GET /api/v1/system/info - Verify system info returns OS details."""
resp = client.get("/api/v1/system/info")
assert resp.status_code == 200, f"Expected 200, got {resp.status_code}"
data = resp.json()
err = validate_envelope(data, "system_info")
assert err is None, f"Envelope validation failed: {err}"
assert data["success"] is True
d = data["data"]
assert "hostname" in d, "Missing hostname"
assert "os" in d, "Missing os"
assert "kernel" in d, "Missing kernel"
assert "architecture" in d, "Missing architecture"
return f"System info: hostname={d['hostname']}, os={d.get('os')}, kernel={d.get('kernel')}"
def test_list_packages(client: PatchAPIClient) -> str:
"""GET /api/v1/packages - Verify package listing with envelope."""
resp = client.get("/api/v1/packages")
assert resp.status_code == 200, f"Expected 200, got {resp.status_code}"
data = resp.json()
err = validate_envelope(data, "list_packages")
assert err is None, f"Envelope validation failed: {err}"
assert data["success"] is True
assert "packages" in data["data"], "Missing packages array"
assert "total" in data["data"], "Missing total count"
assert isinstance(data["data"]["packages"], list), "packages should be a list"
return f"Listed {data['data']['total']} packages"
def test_list_packages_filtered(client: PatchAPIClient) -> str:
"""GET /api/v1/packages?status=installed - Verify filtered package listing."""
resp = client.get("/api/v1/packages?status=installed&limit=10")
assert resp.status_code == 200, f"Expected 200, got {resp.status_code}"
data = resp.json()
assert data["success"] is True
assert "packages" in data["data"]
return f"Filtered packages: {data['data']['total']} installed"
def test_get_package_detail(client: PatchAPIClient) -> str:
"""GET /api/v1/packages/{name} - Verify package detail for a known package."""
resp = client.get("/api/v1/packages/apt")
assert resp.status_code == 200, f"Expected 200, got {resp.status_code}"
data = resp.json()
assert data["success"] is True
pkg = data["data"]
assert "name" in pkg, "Missing package name"
assert pkg["name"] == "apt", f"Expected name=apt, got {pkg['name']}"
assert "version" in pkg, "Missing version"
assert "status" in pkg, "Missing status"
return f"Package detail: {pkg['name']} {pkg.get('version', '?')} ({pkg.get('status', '?')})"
def test_get_package_not_found(client: PatchAPIClient) -> str:
"""GET /api/v1/packages/{nonexistent} - Verify 404 for nonexistent package."""
resp = client.get("/api/v1/packages/xyz-nonexistent-package-12345")
assert resp.status_code == 404, f"Expected 404, got {resp.status_code}"
data = resp.json()
assert data["success"] is False
assert data["error"]["code"] == "PKG_NOT_FOUND", f"Expected PKG_NOT_FOUND, got {data['error']['code']}"
return "Correctly returned PKG_NOT_FOUND for nonexistent package"
def test_install_package(client: PatchAPIClient) -> str:
"""POST /api/v1/packages - Install a safe test package (hello).
Verifies that the package installation completes successfully.
A failed status is a critical failure - the core function must work.
"""
payload = {
"packages": [{"name": TEST_PACKAGE, "version": None}],
"options": {"force": False, "no_recommends": True},
}
resp = client.post("/api/v1/packages", json=payload)
assert resp.status_code == 202, f"Expected 202, got {resp.status_code}: {resp.text}"
data = resp.json()
err = validate_envelope(data, "install_package")
assert err is None, f"Envelope validation failed: {err}"
assert data["success"] is True
assert data["data"]["job_id"], "Missing job_id"
assert data["data"]["status"] == "pending", f"Expected status=pending, got {data['data']['status']}"
assert data["data"]["operation"] == "install", f"Expected operation=install, got {data['data']['operation']}"
# Poll job to completion
job_id = data["data"]["job_id"]
job = poll_job(client, job_id)
assert job["status"] == "completed", f"Install job failed: status={job['status']}, result={job.get('result', {})}"
return f"Installed {TEST_PACKAGE}: job_id={job_id}, status={job['status']}"
def test_update_package(client: PatchAPIClient) -> str:
"""PUT /api/v1/packages/{name} - Update a package."""
resp = client.put(f"/api/v1/packages/{TEST_PACKAGE}", json={"version": None})
assert resp.status_code == 202, f"Expected 202, got {resp.status_code}: {resp.text}"
data = resp.json()
assert data["success"] is True
assert data["data"]["job_id"], "Missing job_id"
assert data["data"]["operation"] == "update"
job_id = data["data"]["job_id"]
job = poll_job(client, job_id)
assert job["status"] == "completed", f"Update job failed: status={job['status']}, result={job.get('result', {})}"
return f"Updated {TEST_PACKAGE}: job_id={job_id}, status={job['status']}"
def test_remove_package(client: PatchAPIClient) -> str:
"""DELETE /api/v1/packages/{name} - Remove the test package.
Verifies that the package removal completes successfully.
A failed status is a critical failure - the core function must work.
"""
resp = client.delete(f"/api/v1/packages/{TEST_PACKAGE}")
assert resp.status_code == 202, f"Expected 202, got {resp.status_code}: {resp.text}"
data = resp.json()
assert data["success"] is True
assert data["data"]["job_id"], "Missing job_id"
assert data["data"]["operation"] == "remove"
job_id = data["data"]["job_id"]
job = poll_job(client, job_id)
assert job["status"] == "completed", f"Remove job failed: status={job['status']}, result={job.get('result', {})}"
return f"Removed {TEST_PACKAGE}: job_id={job_id}, status={job['status']}"
def test_list_patches(client: PatchAPIClient) -> str:
"""GET /api/v1/patches - Verify patch listing."""
resp = client.get("/api/v1/patches")
assert resp.status_code == 200, f"Expected 200, got {resp.status_code}"
data = resp.json()
err = validate_envelope(data, "list_patches")
assert err is None, f"Envelope validation failed: {err}"
assert data["success"] is True
assert "patches" in data["data"], "Missing patches array"
assert "total" in data["data"], "Missing total count"
return f"Listed {data['data']['total']} patches, security_updates={data['data'].get('security_updates', '?')}, requires_reboot={data['data'].get('requires_reboot', '?')}"
def test_list_patches_filtered(client: PatchAPIClient) -> str:
"""GET /api/v1/patches?severity=high - Verify filtered patch listing."""
resp = client.get("/api/v1/patches?severity=high&limit=10")
assert resp.status_code == 200, f"Expected 200, got {resp.status_code}"
data = resp.json()
assert data["success"] is True
return f"Filtered patches: {data['data']['total']} high severity"
def test_apply_patches(client: PatchAPIClient) -> str:
"""POST /api/v1/patches/apply - Test patch apply endpoint.
Uses empty patches list with all packages excluded to avoid actual changes.
"""
payload = {
"patches": [],
"options": {
"reboot": False,
"reboot_delay_minutes": 0,
"exclude_packages": ["*"],
},
}
resp = client.post("/api/v1/patches/apply", json=payload)
if resp.status_code == 202:
data = resp.json()
assert data["success"] is True
assert data["data"]["job_id"], "Missing job_id"
job_id = data["data"]["job_id"]
return f"Patch apply accepted: job_id={job_id}"
elif resp.status_code in [400, 422]:
return f"Patch apply rejected as expected (no patches to apply): HTTP {resp.status_code}"
else:
return f"Patch apply returned HTTP {resp.status_code} - acceptable variant"
def test_list_jobs(client: PatchAPIClient) -> str:
"""GET /api/v1/jobs - Verify job listing."""
resp = client.get("/api/v1/jobs?limit=50", timeout=120)
assert resp.status_code == 200, f"Expected 200, got {resp.status_code}"
data = resp.json()
err = validate_envelope(data, "list_jobs")
assert err is None, f"Envelope validation failed: {err}"
assert data["success"] is True
assert "jobs" in data["data"], "Missing jobs array"
assert "total" in data["data"], "Missing total count"
return f"Listed {data['data']['total']} jobs"
def test_get_job_not_found(client: PatchAPIClient) -> str:
"""GET /api/v1/jobs/{fake_id} - Verify 404 for nonexistent job."""
fake_id = "00000000-0000-0000-0000-000000000000"
resp = client.get(f"/api/v1/jobs/{fake_id}")
assert resp.status_code == 404, f"Expected 404, got {resp.status_code}"
data = resp.json()
assert data["success"] is False
assert data["error"]["code"] == "JOB_NOT_FOUND", f"Expected JOB_NOT_FOUND, got {data['error']['code']}"
return "Correctly returned JOB_NOT_FOUND for nonexistent job"
def test_cancel_job_not_found(client: PatchAPIClient) -> str:
"""DELETE /api/v1/jobs/{fake_id} - Verify 404 for cancel nonexistent job."""
fake_id = "00000000-0000-0000-0000-000000000000"
resp = client.delete(f"/api/v1/jobs/{fake_id}")
assert resp.status_code == 404, f"Expected 404, got {resp.status_code}"
data = resp.json()
assert data["success"] is False
return f"Correctly returned 404 for cancel nonexistent job"
def test_rollback_job_not_found(client: PatchAPIClient) -> str:
"""POST /api/v1/jobs/{fake_id}/rollback - Verify error for rollback nonexistent job.
Note: API may return 400 (invalid job for rollback) or 404 (not found).
Both are acceptable - the important thing is it's not 200.
"""
fake_id = "00000000-0000-0000-0000-000000000000"
resp = client.post(f"/api/v1/jobs/{fake_id}/rollback")
# API may return 400 (can't rollback nonexistent) or 404 (not found)
assert resp.status_code in [400, 404], f"Expected 400 or 404, got {resp.status_code}"
data = resp.json()
assert data["success"] is False
return f"Correctly returned {resp.status_code} for rollback nonexistent job"
def test_invalid_job_id(client: PatchAPIClient) -> str:
"""GET /api/v1/jobs/invalid-uuid - Verify 400 for invalid job ID."""
resp = client.get("/api/v1/jobs/not-a-uuid")
assert resp.status_code == 400, f"Expected 400, got {resp.status_code}"
data = resp.json()
assert data["success"] is False
assert data["error"]["code"] == "INVALID_JOB_ID", f"Expected INVALID_JOB_ID, got {data['error']['code']}"
return "Correctly returned INVALID_JOB_ID for malformed UUID"
def test_method_not_allowed(client: PatchAPIClient) -> str:
"""PATCH /api/v1/packages/apt - Verify unsupported method is rejected.
Note: Actix-web may return 404 for PATCH on resources that don't define it.
Both 404 and 405 are acceptable - the important thing is it's not 200.
"""
resp = client._request("PATCH", "/api/v1/packages/apt")
assert resp.status_code in [404, 405], f"Expected 404 or 405, got {resp.status_code}"
return f"Correctly returned {resp.status_code} for PATCH method (not allowed)"
def test_package_name_validation(client: PatchAPIClient) -> str:
"""GET /api/v1/packages/{long_name} - Verify 400 for oversized package name."""
long_name = "a" * 300
resp = client.get(f"/api/v1/packages/{long_name}")
assert resp.status_code == 400, f"Expected 400, got {resp.status_code}"
data = resp.json()
assert data["success"] is False
return "Correctly rejected oversized package name"
def test_empty_package_install(client: PatchAPIClient) -> str:
"""POST /api/v1/packages with empty name - Verify rejection.
Note: API may return 400, 422, or other error codes for empty package names.
The important thing is it's not accepted as valid.
"""
payload = {
"packages": [{"name": "", "version": None}],
"options": {"force": False},
}
resp = client.post("/api/v1/packages", json=payload)
# API may return 400, 422, or other error codes
if resp.status_code in [400, 422, 500]:
return f"Correctly rejected empty package name with HTTP {resp.status_code}"
elif resp.status_code == 202:
# If accepted, the job should fail - poll to verify
data = resp.json()
if data.get("success"):
job_id = data["data"]["job_id"]
job = poll_job(client, job_id, timeout=30)
if job["status"] == "failed":
return f"Empty package name accepted but job failed as expected: {job_id}"
return f"Empty package name unexpectedly accepted: HTTP {resp.status_code}"
else:
assert False, f"Expected 400/422, got {resp.status_code}: {resp.text[:200]}"
def test_no_cert_connection(client: PatchAPIClient) -> str:
"""Verify that connections without mTLS are silently dropped.
Per spec: non-mTLS connections should be silently dropped (no response).
This means the connection will hang/timeout rather than return an error.
"""
session = requests.Session()
session.verify = False
try:
resp = session.get(
f"https://{client.host}:{client.port}/health",
timeout=10,
)
# If we get here, mTLS is NOT enforced - security issue
assert False, f"Connection without mTLS succeeded! HTTP {resp.status_code} - mTLS not enforced!"
except (requests.exceptions.SSLError, requests.exceptions.ConnectionError, requests.exceptions.ReadTimeout):
# Expected - connection should be dropped (silent drop = no response)
return "Correctly rejected connection without mTLS client certificate"
finally:
session.close()
def test_wrong_cert_connection(client: PatchAPIClient) -> str:
"""Verify that connections with wrong cert are rejected.
Per spec: invalid/expired certificates should be silently dropped.
Uses project test certs (different CA) which should be rejected.
"""
project_ca = "/a0/usr/projects/linux_patch_api/configs/certs/ca.pem"
project_cert = "/a0/usr/projects/linux_patch_api/configs/certs/client001.pem"
project_key = "/a0/usr/projects/linux_patch_api/configs/certs/client001.key.pem"
if not Path(project_ca).exists():
return "SKIPPED: Project test certs not available"
session = requests.Session()
session.cert = (project_cert, project_key)
session.verify = False
try:
resp = session.get(
f"https://{client.host}:{client.port}/health",
timeout=10,
)
assert False, f"Connection with wrong cert succeeded! HTTP {resp.status_code} - cert validation failed!"
except (requests.exceptions.SSLError, requests.exceptions.ConnectionError, requests.exceptions.ReadTimeout):
return "Correctly rejected connection with untrusted client certificate"
finally:
session.close()
def test_job_lifecycle(client: PatchAPIClient) -> str:
"""Full job lifecycle: install -> get job -> list jobs -> remove.
Verifies that install and remove both complete successfully.
A failed status is a critical failure - the core function must work.
"""
# Step 1: Install test package
payload = {
"packages": [{"name": TEST_PACKAGE, "version": None}],
"options": {"force": False, "no_recommends": True},
}
resp = client.post("/api/v1/packages", json=payload)
assert resp.status_code == 202, f"Install failed: HTTP {resp.status_code}"
data = resp.json()
job_id = data["data"]["job_id"]
# Step 2: Get job status
resp = client.get(f"/api/v1/jobs/{job_id}")
assert resp.status_code == 200, f"Get job failed: HTTP {resp.status_code}"
job_data = resp.json()["data"]
assert job_data["job_id"] == job_id, "Job ID mismatch"
# Step 3: Poll to completion
job = poll_job(client, job_id)
assert job["status"] == "completed", f"Install job failed: status={job['status']}, result={job.get('result', {})}"
# Step 4: Verify in job list
resp = client.get("/api/v1/jobs?limit=50", timeout=120)
assert resp.status_code == 200
jobs = resp.json()["data"]["jobs"]
job_ids = [j["job_id"] for j in jobs]
assert job_id in job_ids, f"Job {job_id} not found in job list"
# Step 5: Remove test package
resp = client.delete(f"/api/v1/packages/{TEST_PACKAGE}")
assert resp.status_code == 202, f"Remove failed: HTTP {resp.status_code}"
remove_job_id = resp.json()["data"]["job_id"]
remove_job = poll_job(client, remove_job_id)
assert remove_job["status"] == "completed", f"Remove job failed: status={remove_job['status']}, result={remove_job.get('result', {})}"
return f"Full lifecycle OK: install job={job_id}, remove job={remove_job_id}"
def test_reboot_endpoint(client: PatchAPIClient) -> str:
"""POST /api/v1/system/reboot - Test reboot endpoint.
WARNING: This will actually reboot the target system!
Only run as the LAST test on a target that can tolerate downtime.
Uses a 60-second delay to allow for cancellation if needed.
"""
payload = {
"delay_seconds": 60,
"force": False,
"reason": "E2E test - automated reboot verification",
}
resp = client.post("/api/v1/system/reboot", json=payload)
assert resp.status_code == 202, f"Expected 202, got {resp.status_code}: {resp.text}"
data = resp.json()
err = validate_envelope(data, "reboot")
assert err is None, f"Envelope validation failed: {err}"
assert data["success"] is True
assert data["data"]["job_id"], "Missing job_id"
assert data["data"]["operation"] == "reboot", f"Expected operation=reboot, got {data['data']['operation']}"
job_id = data["data"]["job_id"]
return f"Reboot scheduled: job_id={job_id}, delay=60s. System will reboot in 60 seconds."
# =============================================================================
# Test Runner
# =============================================================================
def run_all_tests(target_key: str, skip_reboot: bool = False, verbose: bool = False) -> TargetResults:
"""Run all E2E tests against a single target."""
target = TARGETS[target_key]
results = TargetResults(
target_name=target["name"],
target_host=target["host"],
)
client = PatchAPIClient(target["host"], target["port"])
print(f"\n{'='*70}")
print(f" Testing: {target['name']} ({target['host']}:{target['port']})")
print(f" OS: {target['os']}")
print(f"{'='*70}")
# ---- Category 1: Health & System ----
print("\n--- Health & System ---")
run_test(results, "Health Check", test_health_endpoint, client)
run_test(results, "System Info", test_system_info, client)
# ---- Category 2: Package Operations ----
print("\n--- Package Operations ---")
run_test(results, "List Packages", test_list_packages, client)
run_test(results, "List Packages (Filtered)", test_list_packages_filtered, client)
run_test(results, "Get Package Detail (apt)", test_get_package_detail, client)
run_test(results, "Get Package Not Found", test_get_package_not_found, client)
run_test(results, "Install Package (hello)", test_install_package, client)
run_test(results, "Update Package (hello)", test_update_package, client)
run_test(results, "Remove Package (hello)", test_remove_package, client)
# ---- Category 3: Patch Operations ----
print("\n--- Patch Operations ---")
run_test(results, "List Patches", test_list_patches, client)
run_test(results, "List Patches (Filtered)", test_list_patches_filtered, client)
run_test(results, "Apply Patches (safe)", test_apply_patches, client)
# ---- Category 4: Job Management ----
print("\n--- Job Management ---")
run_test(results, "List Jobs", test_list_jobs, client)
run_test(results, "Get Job Not Found", test_get_job_not_found, client)
run_test(results, "Cancel Job Not Found", test_cancel_job_not_found, client)
run_test(results, "Rollback Job Not Found", test_rollback_job_not_found, client)
run_test(results, "Invalid Job ID", test_invalid_job_id, client)
run_test(results, "Full Job Lifecycle", test_job_lifecycle, client)
# ---- Category 5: Security ----
print("\n--- Security ---")
run_test(results, "No Cert Connection Rejected", test_no_cert_connection, client)
run_test(results, "Wrong Cert Connection Rejected", test_wrong_cert_connection, client)
run_test(results, "Method Not Allowed (PATCH)", test_method_not_allowed, client)
run_test(results, "Package Name Validation (oversized)", test_package_name_validation, client)
run_test(results, "Empty Package Name Rejected", test_empty_package_install, client)
# ---- Category 6: Reboot (LAST!) ----
print("\n--- Reboot (LAST) ---")
if skip_reboot:
run_test(results, "System Reboot", test_reboot_endpoint, client, skip=True)
print(" ⏭️ SKIPPED (--skip-reboot flag)")
else:
# Only run reboot if all other tests passed
if results.failed == 0 and results.errors == 0:
print(" ⚠️ WARNING: This will reboot the target system!")
run_test(results, "System Reboot", test_reboot_endpoint, client)
else:
print(f" ⏭️ SKIPPED ({results.failed} failures, {results.errors} errors in prior tests)")
run_test(results, "System Reboot", test_reboot_endpoint, client, skip=True)
client.close()
return results
def print_results(results: TargetResults, verbose: bool = False):
"""Print test results summary."""
print(f"\n{'='*70}")
print(f" Results: {results.target_name} ({results.target_host})")
print(f"{'='*70}")
for r in results.results:
status = "" if r.passed else ("⏭️" if "SKIPPED" in r.message else "")
duration = f" ({r.duration_ms:.0f}ms)" if r.duration_ms > 0 else ""
print(f" {status} {r.name}: {r.message}{duration}")
print(f"\n Total: {results.total} | Passed: {results.passed} | Failed: {results.failed} | Errors: {results.errors} | Skipped: {results.skipped}")
if results.failed > 0 or results.errors > 0:
print(f"\n ❌ FAILED")
else:
print(f"\n ✅ ALL PASSED")
def main():
parser = argparse.ArgumentParser(description="Linux Patch API E2E Test Suite")
parser.add_argument(
"--target",
choices=["all", "dev", "u2204", "u2404"],
default="all",
help="Target LXC to test (default: all)",
)
parser.add_argument(
"--skip-reboot",
action="store_true",
help="Skip the reboot test (recommended for initial runs)",
)
parser.add_argument(
"--verbose", "-v",
action="store_true",
help="Verbose output",
)
args = parser.parse_args()
# Verify certs exist
if not CA_CERT.exists():
print(f"ERROR: CA cert not found: {CA_CERT}")
sys.exit(1)
if not CLIENT_CERT.exists():
print(f"ERROR: Client cert not found: {CLIENT_CERT}")
sys.exit(1)
if not CLIENT_KEY.exists():
print(f"ERROR: Client key not found: {CLIENT_KEY}")
sys.exit(1)
print("Linux Patch API - End-to-End Test Suite")
print(f"CA: {CA_CERT}")
print(f"Client Cert: {CLIENT_CERT}")
print(f"Client Key: {CLIENT_KEY}")
targets = list(TARGETS.keys()) if args.target == "all" else [args.target]
all_results = []
overall_passed = True
for target_key in targets:
results = run_all_tests(target_key, args.skip_reboot, args.verbose)
print_results(results, args.verbose)
all_results.append(results)
if results.failed > 0 or results.errors > 0:
overall_passed = False
# Summary across all targets
if len(all_results) > 1:
print(f"\n{'='*70}")
print(" OVERALL SUMMARY")
print(f"{'='*70}")
for r in all_results:
status = "" if (r.failed == 0 and r.errors == 0) else ""
print(f" {status} {r.target_name} ({r.target_host}): {r.passed}/{r.total} passed")
print(f"\n Overall: {'✅ ALL PASSED' if overall_passed else '❌ SOME FAILED'}")
sys.exit(0 if overall_passed else 1)
if __name__ == "__main__":
main()