git-echo/linux_patch_manager
Private
Public Access
1
0
Fork 0
Code Releases 8 Wiki Activity

fix: job completion stuck in running - NULL output and status type mismatch
Some checks failed
CI Pipeline / Rust Format Check (push) Failing after 4s
Details
CI Pipeline / Clippy Lints (push) Successful in 45s
Details
CI Pipeline / Rust Unit Tests (push) Successful in 1m2s
Details
CI Pipeline / Security Audit (push) Successful in 4s
Details
CI Pipeline / Frontend Lint & Type Check (push) Failing after 10s
Details
CI Pipeline / Build .deb & Release (push) Has been skipped
Details

Browse Source 
Bug 1: status.output.as_deref() passes NULL when agent returns no output,
but patch_job_hosts.output has NOT NULL constraint.
Fix: use .unwrap_or("") to default to empty string.

Bug 2: sync_job_status passes String to job_status enum column,
PostgreSQL rejects implicit text-to-enum cast.
Fix: add ::job_status cast in SQL UPDATE queries.
This commit is contained in:
Echo
2026-05-05 20:16:26 +00:00
parent 91c82735d1
commit 0cfe8ba891
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/pm-worker/src/job_executor.rs
View File

@ -690,7 +690,7 @@ async fn poll_single_host(pool: PgPool, config: Arc<AppConfig>, row: PatchJobHos
"#,
)
.bind(row.id)
.bind(status.output.as_deref())
.bind(status.output.as_deref().unwrap_or(""))
.execute(&pool)
.await
{
@ -906,7 +906,7 @@ async fn sync_job_status(pool: &PgPool, job_id: Uuid) {
sqlx::query(
r#"
UPDATE patch_jobs
SET status = $2,
SET status = $2::job_status,
completed_at = COALESCE(completed_at, NOW())
WHERE id = $1
"#,
@ -916,7 +916,7 @@ async fn sync_job_status(pool: &PgPool, job_id: Uuid) {
.execute(pool)
.await
} else {
sqlx::query("UPDATE patch_jobs SET status = $2 WHERE id = $1")
sqlx::query("UPDATE patch_jobs SET status = $2::job_status WHERE id = $1")
.bind(job_id)
.bind(new_status)
.execute(pool)