git-echo/linux_patch_manager
Private
Public Access
1
0
Fork 0
Code Releases 8 Wiki Activity

fix: add public SSO config endpoint for login page

Browse Source 
The SSO button on the login page was not appearing because the settings
API requires authentication, but the login page cannot authenticate before
the user logs in.

Changes:
- Backend: Add GET /api/v1/auth/sso/config public endpoint that returns
  only enabled, display_name, and auth_url (no secrets exposed)
- Backend: Mount sso::public_router() at /api/v1/auth/sso in main.rs
  (was previously missing - only azure_compat_router was mounted)
- Frontend: Replace settingsApi.get() call in LoginPage.tsx with
  ssoConfigApi.get() which calls the public endpoint
- Frontend: Add SsoConfigResponse interface and ssoConfigApi helper
  to client.ts
- Frontend: Use auth_url from config response instead of hardcoded path
This commit is contained in:
Echo
2026-05-13 14:53:12 +00:00
parent 69d2e88bbd
commit d76450759a
4 changed files with 50 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
frontend/src/pages/LoginPage.tsx
View File

@ -11,7 +11,7 @@ import {
Check as CheckIcon, Close as CloseIcon,
Cloud as CloudIcon, VpnKey as KeyIcon,
} from '@mui/icons-material'
import { authApi, settingsApi } from '../api/client'
import { authApi, ssoConfigApi } from '../api/client'
import { useAuthStore } from '../store/authStore'
import type { User } from '../types'
@ -64,6 +64,7 @@ export default function LoginPage() {
const [ssoEnabled, setSsoEnabled] = useState(false)
const [ssoDisplayName, setSsoDisplayName] = useState('SSO')
const [ssoAuthUrl, setSsoAuthUrl] = useState('/api/v1/auth/sso/login')
const [newPassword, setNewPassword] = useState('')
const [confirmNewPassword, setConfirmNewPassword] = useState('')
@ -75,9 +76,10 @@ export default function LoginPage() {
const pwMismatch = !!(confirmNewPassword && newPassword !== confirmNewPassword)
useEffect(() => {
settingsApi.get().then(({ data }) => {
setSsoEnabled(data.oidc.enabled)
setSsoDisplayName(data.oidc.display_name || 'SSO')
ssoConfigApi.get().then(({ data }) => {
setSsoEnabled(data.enabled)
setSsoDisplayName(data.display_name || 'SSO')
if (data.auth_url) setSsoAuthUrl(data.auth_url)
}).catch(() => { /* SSO settings unavailable */ })
}, [])
@ -198,7 +200,7 @@ export default function LoginPage() {
{ssoEnabled && (
<>
<Divider sx={{ my: 3 }}>or</Divider>
<Button fullWidth variant="outlined" size="large" startIcon={ssoIcon} onClick={() => { window.location.href = '/api/v1/auth/sso/login' }} disabled={loading}>Sign in with {ssoDisplayName}</Button>
<Button fullWidth variant="outlined" size="large" startIcon={ssoIcon} onClick={() => { window.location.href = ssoAuthUrl }} disabled={loading}>Sign in with {ssoDisplayName}</Button>
</>
)}
</Box>