Private
Public Access
1
0

fix(tests): resolve all clippy warnings for CI compliance
Some checks failed
CI/CD Pipeline / Code Format (push) Successful in 3s
CI/CD Pipeline / Clippy Lints (push) Successful in 45s
CI/CD Pipeline / All Unit Tests (push) Successful in 1m13s
CI/CD Pipeline / Security Audit (push) Successful in 5s
CI/CD Pipeline / Enrollment Tests (push) Successful in 1m15s
CI/CD Pipeline / Verify Enrollment CLI Flag (push) Successful in 1m4s
CI/CD Pipeline / Build RPM Package (push) Failing after 42s
CI/CD Pipeline / Build Arch Package (push) Successful in 2m55s
CI/CD Pipeline / Build Debian Package (Ubuntu 22.04) (push) Successful in 2m35s
CI/CD Pipeline / Build Debian Package (push) Successful in 2m37s
CI/CD Pipeline / Build Alpine Package (push) Failing after 3m50s

- Remove needless borrows on format!() in set_body_string() calls (needless_borrows_for_generic_args)
- Replace assert!(false, ...) with collected assertion (assertions_on_constants + never_loop)
- Use direct Method::POST comparison instead of to_string() (cmp_owned)
- Simplify negated equality to != operator (nonminimal_bool)

CI pipeline now passes with -D warnings enabled
This commit is contained in:
2026-05-17 16:02:57 +00:00
parent a09e3eaa68
commit 3e8eacab9a
3 changed files with 18 additions and 16 deletions

View File

@ -120,7 +120,7 @@ async fn test_full_enrollment_flow_happy_path() {
.and(path("/api/v1/enroll"))
.respond_with(
ResponseTemplate::new(202)
.set_body_string(&format!(r#"{{"polling_token": "{}"}}"#, TEST_TOKEN)),
.set_body_string(format!(r#"{{"polling_token": "{}"}}"#, TEST_TOKEN)),
)
.named("enroll_registration")
.mount(&server)
@ -135,7 +135,7 @@ async fn test_full_enrollment_flow_happy_path() {
ResponseTemplate::new(200).set_body_string(r#"{"status": "pending"}"#)
} else {
// Second poll returns approved with full PKI bundle
ResponseTemplate::new(200).set_body_string(&format!(
ResponseTemplate::new(200).set_body_string(format!(
r#"{{
"status": "approved",
"ca_crt": {},
@ -414,7 +414,7 @@ async fn test_certificate_permission_verification() {
Mock::given(method("GET"))
.and(path_regex(r"/api/v1/enroll/status/.+"))
.respond_with(ResponseTemplate::new(200).set_body_string(&format!(
.respond_with(ResponseTemplate::new(200).set_body_string(format!(
r#"{{
"status": "approved",
"ca_crt": {},
@ -529,7 +529,7 @@ async fn test_whitelist_append_verification() {
Mock::given(method("GET"))
.and(path_regex(r"/api/v1/enroll/status/.+"))
.respond_with(ResponseTemplate::new(200).set_body_string(&format!(
.respond_with(ResponseTemplate::new(200).set_body_string(format!(
r#"{{
"status": "approved",
"ca_crt": {},
@ -663,14 +663,15 @@ async fn test_signal_handling_during_polling() {
);
// Verify: cleanup of any partial state (no leftover files)
for entry in std::fs::read_dir(cert_dir.path()).unwrap() {
let entry = entry.unwrap();
assert!(
false,
"No partial files should remain after graceful shutdown: {}",
entry.file_name().to_string_lossy()
);
}
let remaining: Vec<_> = std::fs::read_dir(cert_dir.path())
.unwrap()
.map(|e| e.unwrap().file_name().to_string_lossy().to_string())
.collect();
assert!(
remaining.is_empty(),
"No partial files should remain after graceful shutdown: {:?}",
remaining
);
}
// =============================================================================
@ -703,7 +704,7 @@ async fn test_whitelist_yaml_format_preservation() {
Mock::given(method("GET"))
.and(path_regex(r"/api/v1/enroll/status/.+"))
.respond_with(ResponseTemplate::new(200).set_body_string(&format!(
.respond_with(ResponseTemplate::new(200).set_body_string(format!(
r#"{{
"status": "approved",
"ca_crt": {},

View File

@ -11,6 +11,7 @@
use linux_patch_api::enroll::client::EnrollmentClient;
use serial_test::serial;
use wiremock::http::Method;
use wiremock::{
matchers::{method, path, path_regex},
Mock, MockServer, ResponseTemplate,
@ -417,7 +418,7 @@ async fn test_registration_payload_structure() {
let requests = server.received_requests().await.unwrap();
let post_request = requests
.iter()
.find(|r| r.method.to_string() == "POST")
.find(|r| r.method == Method::POST)
.expect("Should have received a POST request");
let body_str = std::str::from_utf8(&post_request.body).expect("Body should be valid UTF-8");

View File

@ -245,7 +245,7 @@ fn test_ip_addresses_are_unicast() {
// Not unspecified (0.0.0.0)
assert!(
!(parts == vec![0, 0, 0, 0]),
parts != vec![0, 0, 0, 0],
"Address '{}' is unspecified",
addr
);
@ -492,7 +492,7 @@ fn test_cross_distro_os_release_parsing() {
parsed.contains_key("NAME"),
"os-release must contain NAME field"
);
assert!(parsed["NAME"].ne(&""), "NAME should not be empty");
assert!(!parsed["NAME"].is_empty(), "NAME should not be empty");
}
#[test]